xupefei commented on code in PR #48120:
URL: https://github.com/apache/spark/pull/48120#discussion_r1831785597
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -2141,7 +2141,9 @@ abstract class DDLSuite extends QueryTest with
DDLSuiteBase {
root = Utils.createTempDir().getCanonicalPath, namePrefix =
"addDirectory")
val testFile = File.createTempFile("testFile", "1", directoryToAdd)
spark.sql(s"ADD FILE $directoryToAdd")
- assert(new
File(SparkFiles.get(s"${directoryToAdd.getName}/${testFile.getName}")).exists())
+ spark.artifactManager.withResources {
Review Comment:
I found that my previous comment was wrong. `ADD JAR` is isolated when used
outside of Hive.
To not bring a behaviour change, I'll make a small change to disable
isolation for this command even outside Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
