gotocoding-DB commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1831606335
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala:
##########
@@ -478,17 +478,26 @@ case class MakeYMInterval(years: Expression, months:
Expression)
override def dataType: DataType = YearMonthIntervalType()
override def nullSafeEval(year: Any, month: Any): Any = {
- Math.toIntExact(Math.addExact(month.asInstanceOf[Number].longValue(),
- Math.multiplyExact(year.asInstanceOf[Number].longValue(),
MONTHS_PER_YEAR)))
+ try {
+ Math.toIntExact(Math.addExact(month.asInstanceOf[Number].longValue(),
+ Math.multiplyExact(year.asInstanceOf[Number].longValue(),
MONTHS_PER_YEAR)))
Review Comment:
I've tried, but failed to `"File 'generated.java', Line 37, Column 68:
Instance method "makeYearMonthInterval" cannot be invoked in static context"`,
so I put this idea aside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
