gotocoding-DB commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1831611112
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2020,11 +2020,23 @@
],
"sqlState" : "XX000"
},
- "INTERVAL_ARITHMETIC_OVERFLOW" : {
- "message" : [
- "<message>.<alternative>"
+ "INTERVAL_ARITHMETIC_OVERFLOW": {
Review Comment:
What I want here.
* We have our usual `ARITHMETIC_OVERFLOW` error, but it suggests to disable
ANSI and try again – it doesn't work in our case, `MakeDTInterval and
MakeYMInterval` always only ansi.
* So we searched for a similar exception for intervals and found this.
`INTERVAL_ARITHMETIC_OVERFLOW` – ideal name for our case with datetime
intervals.
* but we can't have a `hint` (alternative) part, because our hint is strict
unchangeable text just like: "check your data, it doest't fit to 'Int' type",
so I just wrote hardcoded text without alternatives in code. I think it's a
better idea here.
* But I'm definitely not sure about names: `NUMERIC` and `DATETIME` –
strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
