stevomitric opened a new pull request, #48804:
URL: https://github.com/apache/spark/pull/48804

   ### What changes were proposed in this pull request?
   In this PR, UTF8_BINARY performance regression is addressed, that was first 
identified here https://github.com/apache/spark/pull/48721. The regression is 
traced back to this PR https://github.com/apache/spark/pull/48222 when it first 
occurred, however this isn't the actual source of performance degradation.
   
   
   ### Why are the changes needed?
   The PR https://github.com/apache/spark/pull/48222 caused the regression 
because it changed the `collationNameToId` function and made it slightly slower 
by removing a short-circuit for fetching the UTF8_BINARY collation. However 
this function should be called from the benchmark framework at most once - this 
was not the case and it was the largest contributor to performance regression.
   
   The `collationNameToId` was also modified to early-out for `UTF8_BINARY` 
collation.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing testing surface, benchmarks.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to