stevomitric commented on code in PR #48804:
URL: https://github.com/apache/spark/pull/48804#discussion_r1837275265
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala:
##########
@@ -113,13 +113,13 @@ abstract class CollationBenchmarkBase extends
BenchmarkBase {
warmupTime = 10.seconds,
output = output)
collationTypes.foreach { collationType => {
- val collation = CollationFactory.fetchCollation(collationType)
+ val collationId = CollationFactory.collationNameToId(collationType)
Review Comment:
The regression was partially due to benchmarks as well. The
`CollationFactory.collationNameToId` function should only be called fixed
amount of times per query, which shouldn't measurably impact the performance of
the query.
So i think this is the right PR for it, since it was the leading contributor
to the numbers seen in the results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
