gotocoding-DB commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1836654652
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2022,8 +2022,20 @@
},
"INTERVAL_ARITHMETIC_OVERFLOW" : {
"message" : [
- "<message>.<alternative>"
+ "Integer overflow while operating with intervals."
],
+ "subClass" : {
+ "WITHOUT_SUGGESTION" : {
+ "message" : [
+ "Try devising appropriate values for the interval parameters."
+ ]
+ },
+ "WITH_TRY_SUGGESTION" : {
Review Comment:
`TRY` here stands for `try_X` functions which return NULL in case of error.
So I thing actually we're following naming conventions, but it's not clear?
@mihailom-db, do you have some good points here?
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2022,8 +2022,20 @@
},
"INTERVAL_ARITHMETIC_OVERFLOW" : {
"message" : [
- "<message>.<alternative>"
+ "Integer overflow while operating with intervals."
],
+ "subClass" : {
+ "WITHOUT_SUGGESTION" : {
+ "message" : [
+ "Try devising appropriate values for the interval parameters."
+ ]
+ },
+ "WITH_TRY_SUGGESTION" : {
Review Comment:
`TRY` here stands for `try_X` functions which return NULL in case of error.
So I think actually we're following naming conventions, but it's not clear?
@mihailom-db, do you have some good points here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
