mihailom-db commented on code in PR #48773:
URL: https://github.com/apache/spark/pull/48773#discussion_r1839046734
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -636,22 +636,26 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase with ExecutionE
summary = "")
}
- def intervalArithmeticOverflowError(
- message: String,
- hint: String = "",
+ def withSuggestionIntervalArithmeticOverflowError(
+ suggestedFunc: String,
context: QueryContext): ArithmeticException = {
- val alternative = if (hint.nonEmpty) {
- s" Use '$hint' to tolerate overflow and return NULL instead."
- } else ""
new SparkArithmeticException(
- errorClass = "INTERVAL_ARITHMETIC_OVERFLOW",
- messageParameters = Map(
- "message" -> message,
- "alternative" -> alternative),
+ errorClass = "INTERVAL_ARITHMETIC_OVERFLOW.WITH_SUGGESTION",
+ messageParameters = Map("functionName" -> toSQLId(suggestedFunc)),
+ context = getQueryContext(context),
+ summary = getSummary(context))
+ }
+
+ def withoutSuggestionIntervalArithmeticOverflowError(
+ context: QueryContext): SparkArithmeticException = {
+ new SparkArithmeticException(
+ errorClass = "INTERVAL_ARITHMETIC_OVERFLOW.WITHOUT_SUGGESTION",
+ messageParameters = Map(),
context = getQueryContext(context),
summary = getSummary(context))
}
+
Review Comment:
nit: Avoid adding these type of changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
