dongjoon-hyun commented on code in PR #45728:
URL: https://github.com/apache/spark/pull/45728#discussion_r1837189835
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala:
##########
@@ -259,4 +265,55 @@ class KubernetesClusterSchedulerBackendSuite extends
SparkFunSuite with BeforeAn
endpoint.receiveAndReply(context).apply(GenerateExecID("cheeseBurger"))
verify(context).reply("1")
}
+
+ test("Driver attributes") {
Review Comment:
Please add a test name prefix, `SPARK-47573: `.
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala:
##########
@@ -259,4 +265,55 @@ class KubernetesClusterSchedulerBackendSuite extends
SparkFunSuite with BeforeAn
endpoint.receiveAndReply(context).apply(GenerateExecID("cheeseBurger"))
verify(context).reply("1")
}
+
+ test("Driver attributes") {
+ assert(schedulerBackendUnderTest.getDriverAttributes === Some(Map(
+ "LOG_FILES" -> "log"
+ )))
+
+ withEnvs(
+ ENV_DRIVER_ATTRIBUTE_APP_ID -> "spark-app-id",
+ ENV_DRIVER_ATTRIBUTE_KUBERNETES_NAMESPACE -> "default",
+ ENV_DRIVER_ATTRIBUTE_KUBERNETES_POD_NAME -> "pod.name"
+ ) {
+ assert(schedulerBackendUnderTest.getDriverAttributes === Some(Map(
+ "LOG_FILES" -> "log",
+ "APP_ID" -> "spark-app-id",
+ "KUBERNETES_NAMESPACE" -> "default",
+ "KUBERNETES_POD_NAME" -> "pod.name"
+ )))
+ }
+ }
+
+ test("Driver log urls") {
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
