dongjoon-hyun commented on code in PR #45728:
URL: https://github.com/apache/spark/pull/45728#discussion_r1837195855


##########
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala:
##########
@@ -144,6 +144,11 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
       
ThreadUtils.newDaemonSingleThreadScheduledExecutor("cleanup-decommission-execs")
     }
 
+  override def getDriverLogUrls: Option[Map[String, String]] = {

Review Comment:
   Instead of here, please override this at `KubernetesClusterSchedulerBackend` 
instead of `CoarseGrainedSchedulerBackend` because this PR aims for K8s only.
   > For now, only K8s cluster manager supports this configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to