jingz-db commented on code in PR #48124:
URL: https://github.com/apache/spark/pull/48124#discussion_r1837300644
##########
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala:
##########
@@ -529,7 +530,31 @@ class RelationalGroupedDataset protected[sql](
initialStateSchema = initialState.df.schema
)
}
- Dataset.ofRows(df.sparkSession, plan)
+
+ if (eventTimeColumnName.isEmpty) {
+ Dataset.ofRows(df.sparkSession, plan)
+ } else {
+ updateEventTimeColumnAfterTransformWithState(plan, eventTimeColumnName)
+ }
+ }
+
+ /**
+ * Creates a new dataset with updated eventTimeColumn after the
transformWithState
+ * logical node.
+ */
+ private def updateEventTimeColumnAfterTransformWithState(
+ transformWithStateInPandas: LogicalPlan,
+ eventTimeColumnName: String): DataFrame = {
+ val transformWithStateDataset = Dataset.ofRows(
+ df.sparkSession,
+ transformWithStateInPandas
+ )
+
+ Dataset.ofRows(df.sparkSession, EliminateEventTimeWatermark(
Review Comment:
> EliminateEventTimeWatermark is no longer needed as we now have this in
Analyzer rule.
Is this already done? I saw we still keep the TODO here:
https://github.com/apache/spark/blob/d6b733492d3e1643babbcd2b1860e35af7928906/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
