jingz-db commented on code in PR #48124:
URL: https://github.com/apache/spark/pull/48124#discussion_r1837406346
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -542,15 +554,85 @@ def check_results(batch_df, batch_id):
Row(id="a", timestamp="20"),
Row(id="a-expired", timestamp="0"),
}
- else:
+ elif batch_id == 2:
# watermark has not progressed, so timer registered in batch
1(watermark = 10)
# has not yet expired
assert set(batch_df.sort("id").collect()) == {Row(id="a",
timestamp="15")}
+ else:
+ for q in self.spark.streams.active:
+ q.stop()
self._test_transform_with_state_in_pandas_event_time(
EventTimeStatefulProcessor(), check_results
)
+ def _test_transform_with_state_in_pandas_chaining_ops(
Review Comment:
Yeah... It got lost in a merge conflicts. I just added back.
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -542,15 +554,85 @@ def check_results(batch_df, batch_id):
Row(id="a", timestamp="20"),
Row(id="a-expired", timestamp="0"),
}
- else:
+ elif batch_id == 2:
# watermark has not progressed, so timer registered in batch
1(watermark = 10)
# has not yet expired
assert set(batch_df.sort("id").collect()) == {Row(id="a",
timestamp="15")}
+ else:
+ for q in self.spark.streams.active:
+ q.stop()
self._test_transform_with_state_in_pandas_event_time(
EventTimeStatefulProcessor(), check_results
)
+ def _test_transform_with_state_in_pandas_chaining_ops(
Review Comment:
Yeah... It got lost in a resolve of merge conflicts. I just added back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
