cloud-fan commented on code in PR #48653:
URL: https://github.com/apache/spark/pull/48653#discussion_r1837539335
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -179,16 +185,16 @@ class UnivocityParser(
dataType: DataType,
nullable: Boolean = true): ValueConverter = dataType match {
case _: ByteType => (d: String) =>
- nullSafeDatum(d, name, nullable, options)(_.toByte)
+ nullSafeDatum(d, name, nullable, options)(retryWithTrim[Byte](_.toByte))
Review Comment:
the performance will be terrible if most data has whitespace, as now we pay
the per-row cost of error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
