panbingkun commented on code in PR #48653:
URL: https://github.com/apache/spark/pull/48653#discussion_r1837597575
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -179,16 +185,16 @@ class UnivocityParser(
dataType: DataType,
nullable: Boolean = true): ValueConverter = dataType match {
case _: ByteType => (d: String) =>
- nullSafeDatum(d, name, nullable, options)(_.toByte)
+ nullSafeDatum(d, name, nullable, options)(retryWithTrim[Byte](_.toByte))
Review Comment:
Okay, when the end-user sees a return value of `NULL`, we don't seem to have
`a better way` to notice them (if an exception occurs, we may also notice them
in the error message, but in our scenario, it won't). Alright, let's leave it
for now.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
