stevomitric commented on PR #48804: URL: https://github.com/apache/spark/pull/48804#issuecomment-2473138817
> How about to update bechmark results after the revert https://github.com/apache/spark/commit/95b259ecc5c20649993e5d8173aa1b076c0c74ea Decided to make this PR update the benchmarks, and not touch the `CollationFactory` class. Modifying the function in the way you proposed [here](https://github.com/apache/spark/pull/48804#discussion_r1834614134), resulted in very small perf benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
