cloud-fan commented on code in PR #48822:
URL: https://github.com/apache/spark/pull/48822#discussion_r1840273949
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2Writes.scala:
##########
@@ -44,7 +46,7 @@ object V2Writes extends Rule[LogicalPlan] with
PredicateHelper {
override def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {
case a @ AppendData(r: DataSourceV2Relation, query, options, _, None, _) =>
- val writeBuilder = newWriteBuilder(r.table, options, query.schema)
+ val writeBuilder = newWriteBuilder(r.table, r.options.asScala.toMap ++
options, query.schema)
Review Comment:
can we add an assert that only one of them can be non empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]