pan3793 commented on PR #48822: URL: https://github.com/apache/spark/pull/48822#issuecomment-2482321085
I spent a few hours to modify the test cases but they do not work as expected, it seems `SessionConfigSupport` was not considered in the SQL read/write path entirely in the current codebase, though it should be, according to `SessionConfigSupport`'s docs > Data sources can implement this interface to propagate session configs with the specified key-prefix to all data source operations in this session. Making `SessionConfigSupport` work on the SQL read/write path may be out of the scope of this PR, let me try the previous direction and focus on fixing the SQL options propagation issue. > I think assert as @cloud-fan suggest makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
