ueshin commented on code in PR #48829:
URL: https://github.com/apache/spark/pull/48829#discussion_r1842774971
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -95,13 +95,12 @@ private[sql] object Dataset {
def ofRows(sparkSession: SparkSession, logicalPlan: LogicalPlan): DataFrame =
sparkSession.withActive {
val qe = sparkSession.sessionState.executePlan(logicalPlan)
- val encoder = if (qe.isLazyAnalysis) {
- RowEncoder.encoderFor(new StructType())
+ if (qe.isLazyAnalysis) {
Review Comment:
Now with this PR, the encoder creation is lazy only when
`qe.isLazyAnalysis`, to be consistent with the current behavior. Also the
previously failed test suggested to make it consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
