ueshin commented on code in PR #48829:
URL: https://github.com/apache/spark/pull/48829#discussion_r1847155110
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -95,13 +95,12 @@ private[sql] object Dataset {
def ofRows(sparkSession: SparkSession, logicalPlan: LogicalPlan): DataFrame =
sparkSession.withActive {
val qe = sparkSession.sessionState.executePlan(logicalPlan)
- val encoder = if (qe.isLazyAnalysis) {
- RowEncoder.encoderFor(new StructType())
+ if (qe.isLazyAnalysis) {
Review Comment:
Sure, I updated.
I'm not sure [this
change](https://github.com/apache/spark/pull/48829/files#diff-0d94d471b64499a7962de4e9c3335ff5227b80cd85e50cfbd4cab67e41651fb8R1208)
is allowed. I guess we still want to create it eagerly if it's not lazy
analysis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
