neilramaswamy commented on code in PR #48862:
URL: https://github.com/apache/spark/pull/48862#discussion_r1847090795


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -416,6 +429,8 @@ case class TransformWithStateExec(
       StatefulOperatorCustomSumMetric("numMapStateVars", "Number of map state 
variables"),
       StatefulOperatorCustomSumMetric("numDeletedStateVars", "Number of 
deleted state variables"),
       // metrics around timers
+      StatefulOperatorCustomSumMetric("timerProcessingTimeMs",

Review Comment:
   Yes, I verified that it shows up and is non-zero in our UTs. For better 
verification (I agree that us not having _any_ tests for the validity of a 
progress metric is sort of bad), please see [this 
comment](https://github.com/apache/spark/pull/48862#discussion_r1847086603).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to