neilramaswamy commented on code in PR #48862:
URL: https://github.com/apache/spark/pull/48862#discussion_r1847088908
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -343,11 +343,20 @@ case class TransformWithStateExec(
CompletionIterator[InternalRow, Iterator[InternalRow]] = {
val allUpdatesTimeMs = longMetric("allUpdatesTimeMs")
val commitTimeMs = longMetric("commitTimeMs")
- val timeoutLatencyMs = longMetric("allRemovalsTimeMs")
+ val timerProcessingTimeMs = longMetric("timerProcessingTimeMs")
Review Comment:
I think that this PR mainly aims to fix the existing metrics, which, as my
diagram in the description indicates, are unintuitive/wrong.
If we'd like to add a new metric for initial state, I can file a ticket and
take care of it in a separate PR.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -343,11 +343,20 @@ case class TransformWithStateExec(
CompletionIterator[InternalRow, Iterator[InternalRow]] = {
val allUpdatesTimeMs = longMetric("allUpdatesTimeMs")
val commitTimeMs = longMetric("commitTimeMs")
- val timeoutLatencyMs = longMetric("allRemovalsTimeMs")
+ val timerProcessingTimeMs = longMetric("timerProcessingTimeMs")
Review Comment:
I think that this PR mainly aims to fix the existing metrics, which, as my
diagram in the description indicates, are unintuitive/wrong.
If we'd like to add a new metric for initial state, I can file a ticket and
take care of it in a separate fast-follow PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
