stefankandic commented on code in PR #48663:
URL: https://github.com/apache/spark/pull/48663#discussion_r1848609641
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -565,11 +565,14 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
extends TernaryExpression with ExpectsInputTypes {
override def nullIntolerant: Boolean = true
def this(child: Expression, pairDelim: Expression) = {
- this(child, pairDelim, Literal(":"))
+ this(child, pairDelim, Literal.create(":", SQLConf.get.defaultStringType))
Review Comment:
I moved this to the `Literal` itself, but yes the literals should produce
default collation. However, the final state of this depends on the other PR for
resolving default string types. But as of right now, session collation is
always the default one so doing Literal("abc") should return the session
collation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
