cloud-fan commented on code in PR #48663:
URL: https://github.com/apache/spark/pull/48663#discussion_r1849533876
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########
@@ -565,11 +565,14 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
extends TernaryExpression with ExpectsInputTypes {
override def nullIntolerant: Boolean = true
def this(child: Expression, pairDelim: Expression) = {
- this(child, pairDelim, Literal(":"))
+ this(child, pairDelim, Literal.create(":", SQLConf.get.defaultStringType))
Review Comment:
Are you saying that the string literal here must use the session collation?
I think the previous code makes more sense as it uses `object StringType`,
which we can determine the default collation later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
