mihailom-db commented on code in PR #48893:
URL: https://github.com/apache/spark/pull/48893#discussion_r1848992964
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowEvaluatorFactoryBase.scala:
##########
@@ -101,6 +101,8 @@ trait WindowEvaluatorFactoryBase {
val boundExpr = (expr.dataType, boundOffset.dataType) match {
case (DateType, IntegerType) => DateAdd(expr, boundOffset)
case (DateType, _: YearMonthIntervalType) => DateAddYMInterval(expr,
boundOffset)
+ case (DateType, _: DayTimeIntervalType) =>
+ DateAdd(expr, ExtractANSIIntervalDays(boundOffset))
Review Comment:
@MaxGekk just checked. This is the right approach I would say. We are not
trying to change addition for Date + Interval here. We have analyser rule that
converts add(date, interval) to this same expression as in my PR. We are just
adding a case to properly handle case when we need to add interval to a date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
