MaxGekk commented on code in PR #48893:
URL: https://github.com/apache/spark/pull/48893#discussion_r1850283662
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowEvaluatorFactoryBase.scala:
##########
@@ -101,6 +101,8 @@ trait WindowEvaluatorFactoryBase {
val boundExpr = (expr.dataType, boundOffset.dataType) match {
case (DateType, IntegerType) => DateAdd(expr, boundOffset)
case (DateType, _: YearMonthIntervalType) => DateAddYMInterval(expr,
boundOffset)
+ case (DateType, _: DayTimeIntervalType) =>
+ DateAdd(expr, ExtractANSIIntervalDays(boundOffset))
Review Comment:
I think we should support `INTERVAL DAY` (internally `INTERVAL DAY TO DAY`)
as we do in other places, and fail for other day-time intervals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
