cloud-fan commented on code in PR #48546:
URL: https://github.com/apache/spark/pull/48546#discussion_r1851229903
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala:
##########
@@ -88,9 +88,38 @@ case class Collate(child: Expression, collationName: String)
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode):
ExprCode =
defineCodeGen(ctx, ev, (in) => in)
- override def sql: String = s"$prettyName(${child.sql}, $collationName)"
+ override def sql: String = s"$prettyName(${child.sql}, $collation)"
Review Comment:
for resolved collation, we should use the collation name instead of
`ResolvedCollation(name)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
