stevomitric commented on code in PR #48546:
URL: https://github.com/apache/spark/pull/48546#discussion_r1857498775
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala:
##########
@@ -56,7 +57,8 @@ object CollateExpressionBuilder extends ExpressionBuilder {
evalCollation.toString.toUpperCase().contains("TRIM")) {
throw QueryCompilationErrors.trimCollationNotEnabledError()
}
- Collate(e, evalCollation.toString)
+ Collate(e, UnresolvedCollation(
Review Comment:
> The COLLATE function has a dedicate SQL syntax and doesn't need a function
registration.
I Agree. I propose we fix this in a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
