yaooqinn commented on code in PR #48918:
URL: https://github.com/apache/spark/pull/48918#discussion_r1851719183
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala:
##########
@@ -259,32 +264,31 @@ object ReorderAssociativeOperator extends
Rule[LogicalPlan] {
val groupingExpressionSet = collectGroupingExpressions(q)
q.transformExpressionsDownWithPruning(_.containsPattern(BINARY_ARITHMETIC)) {
case a @ Add(_, _, f) if a.deterministic &&
a.dataType.isInstanceOf[IntegralType] =>
- val (foldables, others) = flattenAdd(a,
groupingExpressionSet).partition(_.foldable)
- if (foldables.nonEmpty) {
- val foldableExpr = foldables.reduce((x, y) => Add(x, y, f))
- val foldableValue = foldableExpr.eval(EmptyRow)
+ val (literals, others) = flattenAdd(a, groupingExpressionSet)
+ .partition(_.isInstanceOf[Literal])
+ if (literals.nonEmpty) {
+ val literalExpr = literals.reduce((x, y) => Add(x, y, f))
if (others.isEmpty) {
- Literal.create(foldableValue, a.dataType)
- } else if (foldableValue == 0) {
+ literalExpr
+ } else if (isSameInteger(literalExpr, 0)) {
Review Comment:
shall we inline this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
