dongjoon-hyun commented on code in PR #48918:
URL: https://github.com/apache/spark/pull/48918#discussion_r1852985470
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReorderAssociativeOperatorSuite.scala:
##########
@@ -106,4 +107,17 @@ class ReorderAssociativeOperatorSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+
+ test("SPARK-50380: conditional branches with error expression") {
+ val originalQuery1 = testRelation.select(If($"a" === 1, 1L,
Literal(1).div(0) + $"b")).analyze
+ val optimized1 = Optimize.execute(originalQuery1)
+ comparePlans(optimized1, originalQuery1)
+
+ val originalQuery2 = testRelation.select(
+ If($"a" === 1, 1, ($"b" + Literal(Int.MaxValue)) + 1).as("col")).analyze
+ val optimized2 = Optimize.execute(originalQuery2)
+ val correctAnswer2 = testRelation.select(
+ If($"a" === 1, 1, $"b" + (Literal(Int.MaxValue) + 1)).as("col")).analyze
+ comparePlans(optimized2, correctAnswer2)
Review Comment:
The association is different.
- `originalQuery2`: (A + B) + C
- `correctAnswer2`: A + (B + C)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
