jovanpavl-db commented on code in PR #48739: URL: https://github.com/apache/spark/pull/48739#discussion_r1854134774
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala: ########## @@ -582,7 +582,10 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E override def third: Expression = keyValueDelim override def inputTypes: Seq[AbstractDataType] = - Seq(StringTypeNonCSAICollation, StringTypeNonCSAICollation, StringTypeNonCSAICollation) + Seq( + StringTypeNonCSAICollation(supportsTrimCollation = true), + StringTypeNonCSAICollation(supportsTrimCollation = true), + StringTypeNonCSAICollation(supportsTrimCollation = true)) Review Comment: That's good point, we did implement `StringSplitSQL` expression as trim collation aware, but not in CollationAwareUTF8String itself. Will fix this and add tests for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
