wbo4958 commented on PR #48791: URL: https://github.com/apache/spark/pull/48791#issuecomment-2497632688
> I\ll start reviewing. High-level question: On the PR description you say: > > > Read/write operations for LogisticRegression > > Evaluation of LogisticRegressionModel on a dataset > > What does this mean? What's missing? Now, the new commit has supported `Read/write operations for LogisticRegression` > Evaluation of LogisticRegressionModel on a dataset The [evaluate](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala#L1197) returns a Summary which is not attaching to any model, so we should not retrieve the attribute of the summary according to the chain of `model` -> `summary` -> `attribute`. Instead, we should cache the summary just like the model, and then retrieve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
