Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6508#discussion_r31591231
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -443,9 +466,27 @@ private[spark] class ExecutorAllocationManager(
private def onExecutorIdle(executorId: String): Unit = synchronized {
if (executorIds.contains(executorId)) {
if (!removeTimes.contains(executorId) &&
!executorsPendingToRemove.contains(executorId)) {
+
+ val hasCachedBlocks =
+ executorsWithCachedBlocks.contains(executorId) ||
+
executorEndpoints.get(executorId).exists(_.askWithRetry[Boolean](HasCachedBlocks))
+
+ if (hasCachedBlocks) executorsWithCachedBlocks += executorId
--- End diff --
I just looked through all the `put*` methods in `BlockManager`. It seems
that we always call these methods with `tellMaster = true` for non-broadcast
blocks. This would suggest that the driver should have the most updated states
for the blocks that we care about here.
I think @lianhuiwang is correct. An executor RPC does not seem necessary
here, but I would test it just to be sure (persist, unpersist, evict old
blocks...).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
