dongjoon-hyun commented on code in PR #49003: URL: https://github.com/apache/spark/pull/49003#discussion_r1866523659
########## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala: ########## @@ -53,7 +53,7 @@ private[connect] class ExecuteGrpcResponseSender[T <: Message]( private var interrupted = false // Time at which this sender should finish if the response stream is not finished by then. - private var deadlineTimeMillis = Long.MaxValue Review Comment: Although this is private, is this safe in terms of the compatibility across multiple Spark versions? As you know, we have a compatibility test between Apache Spark 4.0.0 and 3.5.x like the following. There is no compatibility issue with Apache Spark 3.5.x with this change? - https://github.com/apache/spark/actions/workflows/build_python_connect35.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
