changgyoopark-db commented on code in PR #49003: URL: https://github.com/apache/spark/pull/49003#discussion_r1867251328
########## sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala: ########## @@ -53,7 +53,7 @@ private[connect] class ExecuteGrpcResponseSender[T <: Message]( private var interrupted = false // Time at which this sender should finish if the response stream is not finished by then. - private var deadlineTimeMillis = Long.MaxValue Review Comment: There should be no compatibility issues between the 3.5 client because the only public method that allows (indirect) access to this variable is SparkEnv.get.conf.get(CONNECT_EXECUTE_REATTACHABLE_SENDER_MAX_STREAM_DURATION), and the value is correctly converted into nanoseconds at line 202. By the way, is there any way to trigger https://github.com/apache/spark/actions/workflows/build_python_connect35.yml for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
