siying commented on code in PR #49063:
URL: https://github.com/apache/spark/pull/49063#discussion_r1870301738
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/resources/testCommitLogV1CrossVersion/testCommitLog:
##########
@@ -0,0 +1,2 @@
+v1
+{"nextBatchWatermarkMs":1,"stateUniqueIds":{}}
Review Comment:
Do we need to store it as a resource file? Can't we write a temp file from
the code from a constant string?
Also, this file can be generated when unit test runs using class
CommitMetadata so I don't know why we need to store it. It is a good idea to
generate a file with `{"nextBatchWatermarkMs":1}` though, as what @brkyvz said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
