brkyvz commented on code in PR #49063:
URL: https://github.com/apache/spark/pull/49063#discussion_r1870314036
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/resources/testCommitLogV1CrossVersion/testCommitLog:
##########
@@ -0,0 +1,2 @@
+v1
+{"nextBatchWatermarkMs":1,"stateUniqueIds":{}}
Review Comment:
You could also write a constant string too. It just makes it easier to load
the file from resources than to have to write a local file every single test.
Storing persisted data as a resource folder for backwards compatibility
testing is a very common pattern though, that's why I'd prefer to follow that
pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
