Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6612#discussion_r31643435
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
    @@ -139,9 +140,8 @@ private[sql] case class InsertIntoHadoopFsRelation(
         }
     
         def writeRows(taskContext: TaskContext, iterator: Iterator[Row]): Unit 
= {
    -      writerContainer.executorSideSetup(taskContext)
    -
           try {
    +        writerContainer.executorSideSetup(taskContext)
    --- End diff --
    
    Seems it is possible that `executorSideSetup` fails before setting up 
`outputCommitter`. Then, when we call `abortTask`, we will get a NPE since we 
are calling `outputCommitter.abortTask(taskAttemptContext)`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to