Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6612#discussion_r31644085
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
@@ -390,6 +406,7 @@ private[sql] class DefaultWriterContainer(
override def commitTask(): Unit = {
try {
+ assert(writer != null, "OutputWriter instance should have been
initialized")
--- End diff --
Should we throw an exception at here instead of using `assert`? Also, if
`writer == null` is unexpected and we consider it as a bug, should we clearly
let users know they are hitting a bug and they should report stack trace and
information about the use case to us? I mean we need to be more specific on
what a user needs to do when he/she gets `OutputWriter instance should have
been initialized`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
