Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6600#discussion_r31650757
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -146,11 +146,16 @@ private[yarn] class YarnAllocator(
* Request as many executors from the ResourceManager as needed to reach
the desired total. If
* the requested total is smaller than the current number of running
executors, no executors will
* be killed.
+ *
+ * @return Whether the new requested total is different than the old
value.
*/
- def requestTotalExecutors(requestedTotal: Int): Unit = synchronized {
+ def requestTotalExecutors(requestedTotal: Int): Boolean = synchronized {
--- End diff --
The only slightly scary thing is that we have another method with the exact
same signature, but the return value means something different. Since we
document this clearly it should be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
