Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/6600#issuecomment-108570826
Yep, in this case it is likely fine, but is good practice to have the loop
inside the synchronized (the variable that is checked by the loop should be
updated inside the synchronized). Many static analysis tools will flag this
though (not sure about Google ErrorProne though).
On Wednesday, June 3, 2015, andrewor14 <[email protected]> wrote:
> LGTM. I'll let this sit for another day or so in case others have anything
> else to add.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/6600#issuecomment-108548564>.
>
--
Thanks,
Hari
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
