zhengruifeng commented on code in PR #49346:
URL: https://github.com/apache/spark/pull/49346#discussion_r1901441321
##########
python/pyspark/sql/connect/conf.py:
##########
@@ -49,6 +49,20 @@ def set(self, key: str, value: Union[str, int, bool]) ->
None:
set.__doc__ = PySparkRuntimeConfig.set.__doc__
+ def _set_all(self, configs: Dict[str, Union[str, int, bool]], silent:
bool) -> None:
+ conf_list = []
+ for key, value in configs.items():
+ if isinstance(value, bool):
+ value = "true" if value else "false"
+ elif isinstance(value, int):
+ value = str(value)
+ conf_list.append(proto.KeyValue(key=key, value=value))
+ op_set = proto.ConfigRequest.Set(pairs=conf_list, silent=silent)
+ operation = proto.ConfigRequest.Operation(set=op_set)
+ result = self._client.config(operation)
Review Comment:
yes, when `silent` is not set or set False, and trying to set a static config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
