cloud-fan commented on code in PR #49027:
URL: https://github.com/apache/spark/pull/49027#discussion_r1901482282
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/V1WriteCommandSuite.scala:
##########
@@ -93,9 +93,10 @@ trait V1WriteCommandSuiteBase extends SQLTestUtils {
assert(optimizedPlan != null)
// Check whether exists a logical sort node of the write query.
// If user specified sort matches required ordering, the sort node may not
at the top of query.
- assert(optimizedPlan.exists(_.isInstanceOf[Sort]) == hasLogicalSort,
- s"Expect hasLogicalSort: $hasLogicalSort," +
- s"Actual: ${optimizedPlan.exists(_.isInstanceOf[Sort])}")
+ def isSort(plan: LogicalPlan): Boolean =
+ plan.isInstanceOf[Sort] || plan.isInstanceOf[Clustering]
Review Comment:
do most of the test cases expect `Clustering` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
