cloud-fan commented on code in PR #49027: URL: https://github.com/apache/spark/pull/49027#discussion_r1886093570
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -958,6 +958,21 @@ case class Sort( override protected def withNewChildInternal(newChild: LogicalPlan): Sort = copy(child = newChild) } +/** + * @param cluster The clustering expressions + * @param global True means global clustering apply for entire data set, + * False means clustering only apply within the partition. Review Comment: Do we really need this flag? Seems we always require within-partition clustering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
