Ngone51 commented on code in PR #49350: URL: https://github.com/apache/spark/pull/49350#discussion_r1901589059
########## core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceSuite.scala: ########## @@ -14,14 +14,12 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - -package org.apache.spark +package org.apache.spark.deploy Review Comment: Move to `org.apache.spark.deploy` for better access to class within deploy package, e.g., `ApplicationRemoveTest`. And I think it should ideally be put in deploy package given that `ExternalShuffleService` itself also exists in deploy package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
