Ngone51 commented on PR #49350: URL: https://github.com/apache/spark/pull/49350#issuecomment-2576584488
@dongjoon-hyun Thanks for your feedback. Moving the test suites (`ExternalShuffleServiceSuite`) around is because I added a new rpc `ApplicationRemoveTest` within `deploy` package that handled by Worker. And those two test suites can not access `ApplicationRemoveTest` due to the visibility issue. Additionally, given that `ExternalShuffleService` is located within `deploy` package, I finally decided to move the test suites under `deploy` as well. I could also move the rpc `ApplicationRemoveTest` out of `deploy` for the visibility. It would just be a bit weird that all the rpc messages that are handled by the worker locate in `deploy` package except `ApplicationRemoveTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
