LuciferYang commented on PR #49411: URL: https://github.com/apache/spark/pull/49411#issuecomment-2579136936
@cloud-fan @dongjoon-hyun @panbingkun How do we proceed with this issue? I think the risk of generating huge `filter` methods has always existed, but it was hidden in this benchmark because `from_json` did not support code generation previously. So I believe the support of code generation in from_json is not the root cause. As more functions come to support code generation, the probability of generating huge methods will increase, It should apply to more than just filters, right?. Perhaps we need to find a more universal approach to split the generated methods in order to avoid this risk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
