panbingkun commented on PR #49411: URL: https://github.com/apache/spark/pull/49411#issuecomment-2579458063
> Does it mean any time we add codegen support for some functions, there is a risk of perf regression? Are we sure `from_json` is the only one or it's simply because `SubExprEliminationBenchmark` tests `from_json`? So the answer to this question is: In the `SubExprEliminationBenchmark` testing scenario, any expression that implements Codegen will have this issue, not just `from_json`, because our `FilterExec` is inconsistent in `codegen` and `interpreted`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
