grundprinzip commented on code in PR #49443:
URL: https://github.com/apache/spark/pull/49443#discussion_r1910558682
##########
dev/lint-scala:
##########
@@ -17,6 +17,8 @@
# limitations under the License.
#
+set -e
+
Review Comment:
This is a bit of a weird patch. The mvn command should actually continue
checking for `$?` and not for the error output being empty. In particular
because it parses for "Unformatted files"
Not the second issue is that the lint-scala should not care about the code
in
```
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStepSuite.scala
```
The mvn command explicitly just checks for
```
-pl sql/api \
-pl sql/connect/common \
-pl sql/connect/server \
-pl connector/connect/client/jvm \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
