dongjoon-hyun commented on PR #49443: URL: https://github.com/apache/spark/pull/49443#issuecomment-2583083332
> Just failing the command does not help the user to understand how to fix it. This sounds like a wrong claim to me. As I mentioned in the PR description, it fails with the rich information like the following. ``` $ dev/lint-scala Using SPARK_LOCAL_IP=localhost Scalastyle checks failed at following occurrences: [error] /Users/dongjoon/APACHE/spark-merge/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStepSuite.scala:21:0: There should be no empty line separating imports in the same group. [error] /Users/dongjoon/APACHE/spark-merge/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStepSuite.scala:21:0: io.fabric8.kubernetes.api.model.PodSpec is in wrong order relative to org.scalatest.BeforeAndAfter. [error] Total time: 16 s, completed Jan 10, 2025, 7:32:59 AM $ echo $? 1 ``` This also looks wrong to me. `ExecutorKubernetesCredentialsFeatureStepSuite.scala` is a Scala code which is in the scope of `scalastyle` script should cover. > Lastly, my questions still remains why this came up for the ExecutorKubernetesCredentialsFeatureStepSuite.scala file because it's not in scope for the scalastyle check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
