Ngone51 commented on code in PR #49350:
URL: https://github.com/apache/spark/pull/49350#discussion_r1914777730
##########
core/src/test/scala/org/apache/spark/deploy/ExternalShuffleServiceSuite.scala:
##########
@@ -131,8 +106,6 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with
BeforeAndAfterAll wi
val bms = eventually(timeout(2.seconds), interval(100.milliseconds)) {
val locations = sc.env.blockManager.master.getLocations(blockId)
assert(locations.size === 2)
- assert(locations.map(_.port).contains(server.getPort),
- "external shuffle service port should be contained")
Review Comment:
It's just a bit hard to get the port. The test itself already verifies the
external shuffle service works in the end. So I think it might not be worth to
add more changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
