JoshRosen commented on code in PR #49350:
URL: https://github.com/apache/spark/pull/49350#discussion_r1908107990
##########
core/src/test/scala/org/apache/spark/deploy/SslExternalShuffleServiceSuite.scala:
##########
@@ -32,22 +27,8 @@ import org.apache.spark.util.SslTestUtils
*/
class SslExternalShuffleServiceSuite extends ExternalShuffleServiceSuite {
- override def initializeHandlers(): Unit = {
+ override def beforeAll(): Unit = {
SslTestUtils.updateWithSSLConfig(conf)
- val hadoopConf = SparkHadoopUtil.get.newConfiguration(conf);
- // Show that we can successfully inherit options defined in the
`spark.ssl` namespace
- val defaultSslOptions = SSLOptions.parse(conf, hadoopConf, "spark.ssl")
Review Comment:
Otherwise, though, this makes sense: because the superclass was able to be
significantly simplified by retrieving the bind port via RPC
(https://github.com/apache/spark/pull/49350/files#r1908107301) then we don't
need to do this extra layer of copying and plumbing just to wire the
`sslOptions` into the transport confs and other subcomponents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
